staging latest fixes (github oauth) #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…res, may create issues later)
…ependency code (i've broken it while fixing it)
* thinx-class: disable failing test respond with error original_response do not redirect if there is no request/response yet respond with intruder error on invalid token to debug github oauth response on invalid login validation fix; one error remaining expect fixes after potential github-oauth fix by restoring original dependency code (i've broken it while fixing it) restored GHOA to original state debugging GHOA redirect the gitHubOauth seems broken mock object if no nid_data were read from Redis (prevents write failures, may create issues later) fix owner profile call really weird bugs merged recently missing var fix, OMG why is this not reported by any of analyzers? weird errors encountered in messenger added messenger coverage for recently refactored code
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
github-oauth and unauthorized response fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both OAuth logins are broken now, working on that. At least now it's working better than before and there's something to debug.